Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Bard: Fix adding sets with horizontal cursor #9064

Merged
merged 1 commit into from
Dec 1, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion resources/js/components/fieldtypes/bard/Set.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Node } from '@tiptap/core';
import { VueNodeViewRenderer } from '@tiptap/vue-2'
import SetComponent from './Set.vue';
import { TextSelection } from '@tiptap/pm/state';

export const Set = Node.create({

Expand Down Expand Up @@ -54,7 +55,10 @@ export const Set = Node.create({
const { selection } = tr;
const node = this.type.create(attrs);
if (dispatch) {
const transaction = tr.insert(selection.$cursor.pos - 1, node);
const transaction = selection instanceof TextSelection
? tr.insert(selection.$cursor.pos - 1, node)
: tr.insert(selection.$head.pos, node);

dispatch(transaction);
}
},
Expand Down
Loading