[4.x] Fix missing config pass to mount manager #9065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Thank you for this. You've shown what the problem actually was - that the visibility method gets called if the config is missing. On R2 I guess it's not implemented and ends up throwing an exception.
Rather than passing the whole config, I'm now just passing visibility, which is enough to prevent the method from being called.
jasonvarga
approved these changes
Nov 27, 2023
|
@jasonvarga the solution in the image is not about add |
|
This was a confirmed solution. If you're still running into a problem please open a new issue with details. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the config to the MountManager constructor, otherwise the config (from config/filesystems) will be empty and the copyAcrossFilesystem will call visibility method on AwsS3V3Adapter which is unsupported on R2 (and possibly other S3 providers other than AWS).
Closes #7193