[4.x] Provide searchables()->lazy and insertLazily methods to search indexes #9072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
approved these changes
Nov 28, 2023
ryanmitchell
deleted the
fix/use-a-lazy-collection-for-search-insert-multiple
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe not the right approach, but this PR works to reduce the memory usage of searchables()->all() by providing a searchables()->lazy() method returning a less memory heavy LazyCollection. It also updates Algolia and Comb to use this instead of searchables()->all().
It could be possible to take this a step further and have the provider return a lazy collection and then insert each document individually rather than multiple, but that would mean more http calls so maybe thats a trade off.
Should help with #8854