[4.x] Provide searchable entries and terms lazily #9171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the query builder supports lazy, the searchable provider provide() method can make use of that to return documents in a more memory efficient manner.
The PR updates the interface to allow this method to return a LazyCollection and updates both entries and terms to do that. It seems this is not a breaking change, as other providers still return a standard collection and I encountered no errors.
I notice that assets and users are not using a query builder (they are just returning a filtered
all()
), so there is definitely scope to improve things further by updating those providers to do that.This should close #8854