[4.x] Fix error from static caching invalidator when deleting entries #9191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
deleted the
fix/error-when-deleting-entry-with-static-caching-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to fix an issue from the Static Caching invalidator when deleting entries in a structured collection.
When you have a structured collection, the invalidation logic would attempt to get the entry's URL but in doing so it called a method on an entry which no longer existed.
This PR changes when invalidation happens for entries. Instead of it happening after the entry has been deleted (& removed from the tree), it'll happen before the entry is deleted and removed from the tree so the full entry URI is known and to prevent the error from happening.
Fixes #5836.