[4.x] Prevent dirt on saved entry

[vluijkx]

In version 4.35.0, PR #8961 was introduced to show changes from the EntrySaving event in the edit-form UI.

However, the values from the response are in many edge-cases slightly different than the current values. This causes the form to become dirty when an entry is saved. This dirtiness is especially inconvenient when using revisions as it causes the publish button to become disabled. Issue #9068 is an example of this.

This PR disables dirty-tracking while resetting the values from the response.

I am new to the Statamic-codebase and do not know if a timeout is the best approach here. Setting the timeout to 300 did not work which is why I increased it to 350.

[ryanmitchell]

You could use this.$nextTick instead of the timeout - you can see its being used for the emit event

[vluijkx]

Yeah, I have tried to do so like this:

this.trackDirtyState = false

this.values = this.resetValuesFromResponse(response.data.data.values,)

this.$nextTick(() => {
    this.$emit('saved', response)
    this.trackDirtyState = true
})

However, this does not prevent this.values = ... from triggering this.$dirt.add(...).

[duncanmcclean]

Thanks for this! I've managed to get it working with $nextTick instead of using setTimeout.

[vluijkx]

@duncanmcclean Something went wrong here 😅.

Is there a reason to use this.nextTick instead of this.$nextTick?

[duncanmcclean]

Doh! No reason, I'll get that fixed up. Thanks for spotting!

[vluijkx]

Thanks a lot! 🙂

[duncanmcclean]

@vluijkx Should be fixed in the next release. I ended up reverting to your original setTimeout fix because $nextTick didn't work when using Bard fields (#9213).

[Web10-Joris]

@duncanmcclean Just FYI. This is also preventing the 'Create & Link Item' action in the Entry Fieldtype from closing the newly created entry and linking it to the field. Downgraded back to 4.40.0 to check, then it worked again.

[duncanmcclean]

@duncanmcclean Just FYI. This is also preventing the 'Create & Link Item' action in the Entry Fieldtype from closing the newly created entry and linking it to the field. Downgraded back to 4.40.0 to check, then it worked again.

Can you try updating to v4.42.0?

[Web10-Joris]

@duncanmcclean Yep thanks, it is working again in the new release!

[morhi]

Hey @duncanmcclean I think your change might have broken the Link fieldytpe. For instance, when you select "URL" in a Link, that placed anywhere within a Replicator set, it will reset, as soon as you start typing or change anything else in the content. I am using Statamic 4.42.0. Seems like the bug got introduced by 4.41.0, because downgrading to 4.40.0 fixes the issue. Any idea?

[duncanmcclean]

That sounds like a different bug. Can you open a new issue and we can take a look in the new year?

[morhi]

That sounds like a different bug. Can you open a new issue and we can take a look in the new year?

Yes, I did that. That is a good idea. Get some rest and have a blessed Christmas time 🎄