[4.x] Prevent handling field previews when previews are disabled #9353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds some checks to prevent unnecessary field previews from being computed & emitted to parent components when field previews are disabled.
Without these changes, any time a field's value changes, it would compute & emit the field preview, even if it's a root field or the parent Bard/Replicator has field previews disabled.
This should hopefully help somewhat with performance with the Bard & Replicator fieldtypes. 🤞
In the first commit, I made it so the
replicator-preview-updated
event doesn't get emitted when field previews are disabled.Then, in my second commit, I added the same check to the
replicatorPreview
method on the individual fieldtypes because even the fact we're generating them in the first place is going to have some kind of performance impact, especially for fields with larger values (like Bards & Replicators).Maybe we don't need the checks in both places, maybe we do. Happy to change it.
Closes #9248.
Potentially helps with #9351.