Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] Fix Glide cache not clearing on image reupload if append_original_filename is enabled #9610

Merged
merged 3 commits into from
Mar 22, 2024
Merged

[4.x] Fix Glide cache not clearing on image reupload if append_original_filename is enabled #9610

merged 3 commits into from
Mar 22, 2024

Conversation

daun
Copy link
Contributor

@daun daun commented Feb 28, 2024 •
edited by duncanmcclean
Loading

Fixes #9609

Description

  • Make sure that reuploading an image will always clear the Glide cache, even if append_original_filename is enabled

Required changes

  • Use the default Glide cache path callable during cache deletion

Tests

  • No new tests for now
  • First-time contributor here and having a bit of trouble finding my way through the test setup
  • Might revisit that if I find the time

@duncanmcclean duncanmcclean linked an issue Feb 28, 2024 that may be closed by this pull request
Glide cache not cleared on reupload if append_original_filename is enabled #9609
Closed
@jasonvarga jasonvarga mentioned this pull request Mar 1, 2024
Merged
@daun daun requested a review from ryanmitchell March 5, 2024 11:53
@daun
Copy link
Contributor Author

daun commented Mar 12, 2024

@duncanmcclean Anything I can do or add to make this happen? Not sure about the process here :)

@jasonvarga
Copy link
Member

You're okay. We'll get to it when we have a chance.

@jasonvarga jasonvarga merged commit 9b33361 into statamic:4.x Mar 22, 2024
18 checks passed
@daun daun deleted the fix/clear-glide-cache-on-reupload-if-appending-filename branch October 25, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanmitchell ryanmitchell Awaiting requested review from ryanmitchell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Glide cache not cleared on reupload if append_original_filename is enabled
3 participants
@daun @jasonvarga @ryanmitchell