Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Update deprecated contract usages in custom validation rules #9780

Merged
merged 10 commits into from
Mar 25, 2024
Merged

[5.x] Update deprecated contract usages in custom validation rules #9780

merged 10 commits into from
Mar 25, 2024

Commits on Mar 22, 2024

  1. Add ValidatesCustomRule testing helper trait.

    @jesseleite
    jesseleite committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    dcc84e7 View commit details
    Browse the repository at this point in the history

  2. Write passing test for EmailAvailable rule.

    @jesseleite
    jesseleite committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    8c09538 View commit details
    Browse the repository at this point in the history

  3. Refactor EmailAvailable rule to use new ValidationRule contract.

    @jesseleite
    jesseleite committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    f9ad189 View commit details
    Browse the repository at this point in the history

  4. Write passing test for ComposerPackage rule.

    @jesseleite
    jesseleite committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    a975aed View commit details
    Browse the repository at this point in the history

  5. Refactor ComposerPackage rule to use new ValidationRule contract.

    @jesseleite
    jesseleite committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    dc8efda View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. nitpick inb4 Jason does 🙃

    @jesseleite
    jesseleite committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e2996d8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into chore/update-deprecated-validation-rules

    @jasonvarga
    jasonvarga committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    792a79c View commit details
    Browse the repository at this point in the history

  3. consistency

    @jasonvarga
    jasonvarga committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    bc605f7 View commit details
    Browse the repository at this point in the history

  4. avoid asserting exact string

    @jasonvarga
    jasonvarga committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    2674de2 View commit details
    Browse the repository at this point in the history

  5. here too

    @jasonvarga
    jasonvarga committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    48e7393 View commit details
    Browse the repository at this point in the history