-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Cache entry uri #9844
Merged
Merged
[5.x] Cache entry uri #9844
Commits on Apr 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0cfc2e1 - Browse repository at this point
Copy the full SHA 0cfc2e1View commit details
Commits on Apr 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 74f01a2 - Browse repository at this point
Copy the full SHA 74f01a2View commit details
Commits on Apr 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e1aef40 - Browse repository at this point
Copy the full SHA e1aef40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95be09a - Browse repository at this point
Copy the full SHA 95be09aView commit details
Commits on Apr 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f9cffe0 - Browse repository at this point
Copy the full SHA f9cffe0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0d2e86 - Browse repository at this point
Copy the full SHA e0d2e86View commit details -
Configuration menu - View commit details
-
Copy full SHA for add8255 - Browse repository at this point
Copy the full SHA add8255View commit details -
compare ids since the objects arent technically identical (computedCa…
…cheCallback property is different)
Configuration menu - View commit details
-
Copy full SHA for 88d1159 - Browse repository at this point
Copy the full SHA 88d1159View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ae2be0 - Browse repository at this point
Copy the full SHA 7ae2be0View commit details
Commits on Apr 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1deddc3 - Browse repository at this point
Copy the full SHA 1deddc3View commit details
Commits on Apr 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fdc19f0 - Browse repository at this point
Copy the full SHA fdc19f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for bba4d75 - Browse repository at this point
Copy the full SHA bba4d75View commit details
Commits on Apr 29, 2024
-
Fix test by moving the tag before content creation ...
When the uri is evaluated, the parser caches the tag list. Since the tag isn't available at that point, when we try to use it in the view, it's missing. Moving the tag registration earlier makes it available when the parser does the uri. It's more reflective of a real life solution anyway. Tags would be registered early.
Configuration menu - View commit details
-
Copy full SHA for 6ba8099 - Browse repository at this point
Copy the full SHA 6ba8099View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0664168 - Browse repository at this point
Copy the full SHA 0664168View commit details -
Configuration menu - View commit details
-
Copy full SHA for 972ee90 - Browse repository at this point
Copy the full SHA 972ee90View commit details -
First of all, a slug of just a slash is a bit weird. Surprising it worked to begin with. Second, now that when generating the uri, it might end up reading the file again. Since the collectino created a line above requires slugs by default, it took the filename which was just the id, and used it as a slug. When we did ->get('/') it would 404 because it thinks the uri is actually /1. Easy fix is to just use an explicit not-a-slash slug.
Configuration menu - View commit details
-
Copy full SHA for 1a76cff - Browse repository at this point
Copy the full SHA 1a76cffView commit details -
compare ids. the objects might be have different properties - like th…
…e computedCallbackCache for example
Configuration menu - View commit details
-
Copy full SHA for f740018 - Browse repository at this point
Copy the full SHA f740018View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f90874 - Browse repository at this point
Copy the full SHA 0f90874View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.