Enable nitro payment integration using an env var #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalexgap
commented
Jul 12, 2023
| @@ -80,6 +80,8 @@ services: | |||
| - BOOST_PATH=/var/lib/boost | |||
| - LOTUS_PATH=/var/lib/lotus | |||
| - LOTUS_MINER_PATH=/var/lib/lotus-miner | |||
| - BOOSTER_HTTP_NITRO_ENABLED=${BOOSTER_HTTP_NITRO_ENABLED:-false} | |||
There was a problem hiding this comment.
The :- syntax lets us provide a default value if the env var is not set.
lalexgap
changed the title
geoknee
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Looks good.
This prompts me to think that we need some docs to explain to boost users:
- how to enable nitro
- what that means / enables for them.
Perhaps we should make an issue to cover this. I believe the boost maintainers are going to want to see that before considering our work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
Currently in our
nitro-integrationbranch we modify the entrypoint for booster-http to always enable nitro . This means our branch basically requires a nitro rpc server setup if you're running the dockerized booster http, which is not very pratical.This PR updates the docker compose so the env var
BOOSTER_HTTP_NITRO_ENABLEDcan be used to enable the nitro integration. The default behavior, if that env var is not set, is to assume no nitro integration. I've also addedBOOSTER_HTTP_NITRO_ENDPOINT, which defaults tohost.docker.internal:4007/api/v1. This can be used if there's a different endpoint we want to use for some reason.With these changes we now need to set
BOOSTER_HTTP_NITRO_ENABLEDwhen triggering docker compose if we want to enable the nitro payment integration. To do so you just need to setBOOSTER_HTTP_NITRO_ENABLED=truewhen calling compose. IE: