Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for virtual defund objective to complete #98

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

lalexgap
Copy link
Contributor

Fixes #83

This PR updates our test so we wait for the virtual defund objective to complete before moving on.

Previously we wouldn't wait for the virtual defund objective to complete. This meant that we could attempt to close a ledger channel while we still had running virtual defund objectives. Closing a ledger channel too early silent fails which causes the whole test to stall out.

With this PR I can run

testground --endpoint=http://34.168.92.245:8042  run s -p=go-nitro-testground -t=virtual-payment -b=docker:go -r=local:docker -tp=numOfHubs=1 -tp=numOfPayers=10 -tp=numOfPayees=1  -i=12  -tp=paymentTestDuration=20  -tp=concurrentPaymentJobs=5

and have it pass where previously it would fail closing ledger channels.

@lalexgap lalexgap merged commit c3beda5 into main Sep 22, 2022
@lalexgap lalexgap deleted the wait-for-virtual-defund branch September 22, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test fails when closing ledgers
2 participants