Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🏠 Internal]: Allow edge releases in marketplace #35

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

christian-bromann
Copy link
Contributor

Is your feature request related to a problem?

Currently edge releases have the following format: 3.0.0-edge.1 which is valid semver but invalid as version to be published on the marketplace (see also microsoft/vscode-vsce#148 for context). This means that edge releases are currently not possible with the workflow we have.

Describe the solution you'd like.

To fix this I suggest to add an additional re-packaging step to the workflow that would modify: 3.0.0-edge.1 to be 3.0.<year><month><day><hour><minute>, so e.g. 3.0.202202221641.

Describe alternatives you've considered.

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

@christian-bromann christian-bromann added the Idea 💡 Any ideas or feedback you have for Marquee label Feb 22, 2022
@christian-bromann christian-bromann added this to the v3 milestone Feb 25, 2022
@vercel
Copy link

vercel bot commented Feb 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/stateful/vscode-marquee/CDFa5MMjVD9auoEZePbu2AByKhLf
✅ Preview: Canceled

@christian-bromann christian-bromann merged commit 8e21e50 into main Feb 25, 2022
@christian-bromann christian-bromann deleted the cb-edge-release-fix branch March 7, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea 💡 Any ideas or feedback you have for Marquee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant