Skip to content

Commit

Permalink
Trigger GhostCells On Cell Execution (#1744)
Browse files Browse the repository at this point in the history
* Fix

* Cleanup.

* Update the comment.

* Try to use onDidChangeActiveTextEditors and onDidChangeVisibleTextEditors; that doesn't work. probably because the outputs aren't text editors.

* Start hacking on using the notebook change event.

* Success we appear to be successfully trigger when output updates and output appears to get sent at least if the cell is non-interactive.

* Add comment.

* Comment out changes to try to see why execution in non-interactive cells is no longer working.

* Revert "Comment out changes to try to see why execution in non-interactive cells is no longer working."

This reverts commit 2d650a6.

* Cleanup.

* Revert changes to trigger completions on doExecute. It seems redundant.

* Revert examples

* Revert changes to contributing.md

* Add lock file

---------

Co-authored-by: Sebastian Tiedtke <sebastiantiedtke@gmail.com>
  • Loading branch information
jlewi and sourishkrout authored Oct 25, 2024
1 parent 518924e commit ce0e743
Show file tree
Hide file tree
Showing 5 changed files with 550 additions and 391 deletions.
Loading

0 comments on commit ce0e743

Please sign in to comment.