-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider CustomExecution over ShellExecution #3
Comments
Here's a PoC implementation: https://github.com/stateful/vscode-runme/blob/main/src/extension/terminal.ts |
Limited access and control over stdin through to the Pseudoterminal interface. Not actionable beyond PoC. |
mxsdev
added a commit
that referenced
this issue
Apr 24, 2023
* Runme e2e tests * Fix missing e2e tests * Organize code and fix failing test * Runme e2e tests * main fixes * focus next cell editor * cycle through cells properly * fix tests * try waiting * refactor getcommand * wait for clickable * don't click it * await terminalbutton clickable * alternative selector method * clear notifications * fix tests again * skip stdin example * wait time * skip piping to env variable * skip curling image * fix stdin example * ci test * remove ci testing error * better test name * revert ci testing changes * re-enable single line environment variable * fix path test * fix multiple line test * try fix image curl * fix focus * ci test #1 * ci test #2 * ci test #3 * ci test #4 * ci test #5 * ci test #6 * ci test #7 * ci test #8 * ci test #9 * ci test #10 * "ci test 11" * "ci test 12" * "ci test 13" * "ci test 14" * "ci test 15" * "ci test 16" * "ci test 17" * "ci test 18" * "ci test 19" * "ci test 20" * "ci test 21" * "ci test 22" * "ci test 23" * "ci test 24" * "ci test 25" * "ci test 26" * "ci test 27" * "ci test 28" * "ci test 29" * "ci test 30" * "ci test 31" * "ci test 32" * "ci test 33" * "ci test 34" * "ci test 35" * "ci test 36" * "ci test 37" * "ci test 38" * "ci test 39" * "ci test 40" * "ci test 41" * "ci test 42" * "ci test 43" * "ci test 44" * "ci test 45" * "ci test 46" * "ci test 47" * "ci test 48" * "ci test 49" * "ci test 50" --------- Co-authored-by: Ruben Restrepo <ruben@stateful.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's a chance it might simplify the initializing of a task and provide access to stdout (if required). There's also a chance it might just work as a wrapper for inline-execution.
From the VS Code API:
The text was updated successfully, but these errors were encountered: