Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additional headers to support better debugging in the cloud platform #1732

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

pastuxso
Copy link
Contributor

@pastuxso pastuxso commented Oct 15, 2024

The user agent header is incorrectly set to node-fetch/1.0 (+https://github.com/bitinn/node-fetch), instead of reflecting the actual VS Code platform.

New headers example:

image

@pastuxso pastuxso force-pushed the cris/http-client-headers branch from 95e6505 to d4e9b50 Compare October 15, 2024 16:34
@pastuxso pastuxso marked this pull request as ready for review October 15, 2024 17:00
@pastuxso pastuxso requested a review from sourishkrout October 15, 2024 17:00
…ents.

Fixes an issue where the user agent header is incorrectly set to
`node-fetch/1.0 (+https://github.com/bitinn/node-fetch)`, instead of reflecting the
actual VS Code platform.
@pastuxso pastuxso force-pushed the cris/http-client-headers branch from d4e9b50 to 9d9bf94 Compare October 15, 2024 18:23
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@pastuxso pastuxso merged commit fff7903 into main Oct 15, 2024
1 check passed
@pastuxso pastuxso deleted the cris/http-client-headers branch October 15, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants