Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vscode from 1.78.0 to 1.95.0 #1796

Closed
wants to merge 1 commit into from
Closed

Conversation

pastuxso
Copy link
Contributor

@pastuxso pastuxso commented Nov 15, 2024

This PR updates the vscode dependency to version 1.95.0

@sourishkrout
Copy link
Member

We don't want to upgrade to the latest because if we do this, we must require the extension only to run 1.95+ up. We want maximum backward compatibility and only move forward if new APIs require it. Is this the motivation @pastuxso?

@pastuxso
Copy link
Contributor Author

@sourishkrout, the purpose of this pull request was to identify what is blocking us from upgrading our codebase to the latest VS Code types, as suggested by Dependabot. During this process, I found a minor breaking change.

I have created this separate draft to document this finding. I think it can be frozen or closed.

We should probably consider setting a new minimum version according to the following table:

Operating System Last Compatible VS Code Version Not Compatible Starting From Version
Windows 7 1.70.3 1.71
Windows 8 and 8.1 1.79 1.80
Windows 32-bit 1.83 1.84
macOS Mojave (version 10.14 and earlier) 1.85 1.86
Linux (distributions with glibc < 2.28) 1.85 1.86.1

Source: https://code.visualstudio.com/docs/supporting/FAQ#_can-i-run-vs-code-on-older-windows-versions

@pastuxso
Copy link
Contributor Author

@sourishkrout According to the table, I think we can jump into the v1.85 as the new minimum version.

@pastuxso pastuxso closed this Nov 27, 2024
@pastuxso
Copy link
Contributor Author

Closed in favor of #1823

@pastuxso pastuxso deleted the cris/vscode-runtime-v1.95 branch November 27, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants