Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More improvements to export statements #37

Merged
merged 5 commits into from
Nov 1, 2022

Conversation

christian-bromann
Copy link
Contributor

fixes #32

This patch includes:

  • moving code into utils file for better testability
  • unit test coverage for handling export lines in shell code
  • support exports with single quotes (e.g. export Foo='bar')

Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the multi-line still working for you @christian-bromann?

it looks like it chops off everything after the first line now.

image

@christian-bromann
Copy link
Contributor Author

Should be fixed now, added test for this case. Please have another look.

@sourishkrout sourishkrout self-requested a review November 1, 2022 02:24
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

@christian-bromann christian-bromann merged commit 6e50be8 into main Nov 1, 2022
@christian-bromann christian-bromann deleted the cb-export-improvements branch November 9, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues parsing ENV with multiple variable definitions
2 participants