Adjust data.internal extraction
#475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Andarist
force-pushed
the
adjust-internal
branch
from
a49fcb8 to
b226f8a
Compare
Andarist
force-pushed
the
transition-insertions
branch
from
d13ddf6 to
d393502
Compare
Andarist
force-pushed
the
adjust-internal
branch
from
b226f8a to
3f01986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it turns out that this is a tristate (
internal: boolean | undefined) property in the Studio so I've adjusted the code here accordingly. Some extra tests will be required when I start portingmark_transition_as_externaltests - I will remember about adding them at that point 😉