Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement action insertions #480

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Implement action insertions #480

merged 1 commit into from
Mar 11, 2024

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Mar 5, 2024

No description provided.

@Andarist Andarist requested a review from davidkpiano March 5, 2024 22:24
Copy link

changeset-bot bot commented Mar 5, 2024

⚠️ No Changeset found

Latest commit: fc2712c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines +275 to +276
entry: ["doStuff",
"bark", "meow"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-item array wrapping could use some work - it's not incorrect right now, it just ain't pretty. For that reason, I don't intend to improve this rn

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine

states: {
a: {
invoke: {
src: "callDavid",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📴

@Andarist Andarist merged commit f77c322 into scaffold-new-version Mar 11, 2024
1 check passed
@Andarist Andarist deleted the add-action branch March 11, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants