-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to .Net 8 + Update Nuget Packages to non vulnerable version #278
base: main
Are you sure you want to change the base?
Changes from 1 commit
89cbf2e
ca39a14
4488198
1f83968
11f3cf8
c83e551
f158438
04eaef6
b2daed9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Technically Struct is actually more correct, but seems that prior frameworks reported SpecificKind as Structure. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With more recent Handlebars version, the BlockHelper needs to be started by # - can be seen in the official handlebars repository. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Applied Globalization on TestFixture, however only two tests had been affected on my local machine by the coma seperator due to german localization. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Collections.Immutable; | ||
using System.Globalization; | ||
using System.Linq; | ||
using System.Text; | ||
using System.Threading.Tasks; | ||
|
@@ -14,6 +15,14 @@ namespace Statiq.Lunr.Tests | |
[TestFixture] | ||
public class GenerateLunrIndexFixture : BaseFixture | ||
{ | ||
[SetUp] | ||
public void SetUp() | ||
{ | ||
// Set the culture to en-US for the tests, otherwise tests with decimals fail on machines with , as decimal seperator | ||
CultureInfo.CurrentCulture = new CultureInfo("en-US"); | ||
CultureInfo.CurrentUICulture = new CultureInfo("en-US"); | ||
} | ||
|
||
public class ExecuteTests : GenerateLunrIndexFixture | ||
{ | ||
[Test] | ||
|
@@ -541,7 +550,7 @@ public async Task ConvertsSearchableField(object value, string expected) | |
|
||
// Then | ||
TestDocument indexDocument = results.ShouldHaveSingleWithDestination(GenerateLunrIndex.DefaultScriptPath.ChangeExtension(".index.json")); | ||
indexDocument.Content.ShouldContain(expected); | ||
indexDocument.Content.ShouldContainWithoutWhitespace(expected); // ShouldContain is clipped to first 100 chars, but occurrence is beyond. This method is not clipped; Workaround | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was a little more tricky - ShouldContain is (now?) clipped to 100 chars and the match is actually in the testdocument content - however all further text is cut-off with "..." as such the test fails. ShouldContainWithoutWhitespace is the only extension method, which is not clipping the actual. Tried to explain through comment, so it's not reversed as it's not very "intuitive" |
||
} | ||
|
||
[Test] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an actual mistake by me in translating the "old" asserts into the "new" - so corrected.