Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimir 1873 lib time more formats #2115

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

omsaggau
Copy link
Contributor

No description provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

return dateFnsResult
}

// log.info(`${date} -- ${formatType} -- date-fns: ${dateFnsResult}, lib-time: ${libTimeResult}`)

// Track errors in logs
if (dateFnsResult && dateFnsResult !== libTimeResult) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skulle ikke dateFnsResult brukes hvis disse 2 datoene var ulike?

Copy link
Contributor

@ssb-cgn ssb-cgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but have added a comment.

@omsaggau omsaggau merged commit bff1ae5 into master Oct 2, 2023
6 checks passed
@omsaggau omsaggau deleted the MIMIR-1873_lib-time-more-formats branch October 5, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants