MIM-1887 gtag and GA_TRACKING_ID removal #2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Carl-OW
changed the title
Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 2.1.2 to 2.1.3. - [Release notes](https://github.com/google-github-actions/auth/releases) - [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md) - [Commits](google-github-actions/auth@v2.1.2...v2.1.3) --- updated-dependencies: - dependency-name: google-github-actions/auth dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#2756) MIM-1950:Fikset bug med tidssone for kommende publiseringer
* added macro config for keyFigure * added styling to fix gap to text * fixed formatting
* Updated comment for GA4 gtag config * Fjernet UA script
ssb-cgn
reviewed
May 31, 2024
ssb-cgn
reviewed
May 31, 2024
ssb-cgn
reviewed
May 31, 2024
src/main/resources/site/parts/searchResult/searchResultView.tsx
Outdated
Show resolved
Hide resolved
ssb-cgn
reviewed
May 31, 2024
ssb-cgn
reviewed
May 31, 2024
Carl-OW
force-pushed
the
MIM-1887-gtag_removal
branch
2 times, most recently
from
ba60330 to
8b44cfa
Compare
annesiri
reviewed
May 31, 2024
| @@ -66,7 +66,6 @@ const previewOverride: object = { | |||
| contentList: 'relatedFactPage', | |||
| } | |||
|
|
|||
| export const GA_TRACKING_ID: string | null = app.config?.GA_TRACKING_ID || null | |||
There was a problem hiding this comment.
Siden vi henter denne fra config betyr det at vi må rydde bort GA_TRACKING_ID i mimir-config-repo også. Må vel gjøres etter at vi har deployet til alle miljøene for å gjøre det enkelt :)
annesiri
previously approved these changes
May 31, 2024
|
annesiri
approved these changes
Jun 3, 2024
Carl-OW
added a commit
that referenced
this pull request
Jun 4, 2024
* Add PageMap attributes, feature toggle * [MIM-1950] MIM-1950:Fikset bug med tidssone for kommende publiseringer (#2756) MIM-1950:Fikset bug med tidssone for kommende publiseringer * Change env name in github action to make jira integration work properly (#2764) * [MIM-1915] Added macro config for keyFigure (#2759) * added macro config for keyFigure * added styling to fix gap to text * fixed formatting * Add conditional fields, if data is present. * [MIM-1887] Mim 1887 removal of universal analytics (#2763) * Updated comment for GA4 gtag config * Fjernet UA script * Added description and title after code review * Keywords should be an array, I think. * Remove title, it looks wrong sometimes and shouldnt be fetched like this. * [MIM-1887] UA script for TEST (#2772) UA script for TEST * MIM-1887 gtag and GA_TRACKING_ID removal (#2769) * highchart.es6 gtag removal * AttachmentTablesFigures gtag removal * Highchart.jsx gtag removal * links.tsx gtag removal * Table.tsx gtag removal * nameSearch.jsx gtag removal * searchResultView.tsx gtag removal * error.html gtag removal * ReactGA.tsx removal of file * react-ga dependency removal * GA_TRACKING_ID removal from all files * Bump google-github-actions/auth from 2.1.2 to 2.1.3 (#2757) Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 2.1.2 to 2.1.3. - [Release notes](https://github.com/google-github-actions/auth/releases) - [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md) - [Commits](google-github-actions/auth@v2.1.2...v2.1.3) --- updated-dependencies: - dependency-name: google-github-actions/auth dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update version number to v2.8.2 * [MIM-1950] MIM-1950:Fikset bug med tidssone for kommende publiseringer (#2756) MIM-1950:Fikset bug med tidssone for kommende publiseringer * Change env name in github action to make jira integration work properly (#2764) * [MIM-1915] Added macro config for keyFigure (#2759) * added macro config for keyFigure * added styling to fix gap to text * fixed formatting * [MIM-1887] Mim 1887 removal of universal analytics (#2763) * Updated comment for GA4 gtag config * Fjernet UA script * Changes to Commits * Added type for renderShowButton onKeyDown event * default.html - UA SCRIPT final removal --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions Bot <> Co-authored-by: Carina <47381367+ssb-cgn@users.noreply.github.com> Co-authored-by: Anne-Siri <142512638+annesiri@users.noreply.github.com> * [MIM-1915] Add divider to key figure macro (#2775) * added divider in keyFigure macro * moved divider logic to keyFigure part --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Glenruben Larsen <gle@ssb.no> Co-authored-by: Carina <47381367+ssb-cgn@users.noreply.github.com> Co-authored-by: Anne-Siri <142512638+annesiri@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
johnnadeluy
added a commit
that referenced
this pull request
Jun 10, 2024
PROD Løft (#2776) * Add PageMap attributes, feature toggle * [MIM-1950] MIM-1950:Fikset bug med tidssone for kommende publiseringer (#2756) MIM-1950:Fikset bug med tidssone for kommende publiseringer * Change env name in github action to make jira integration work properly (#2764) * [MIM-1915] Added macro config for keyFigure (#2759) * added macro config for keyFigure * added styling to fix gap to text * fixed formatting * Add conditional fields, if data is present. * [MIM-1887] Mim 1887 removal of universal analytics (#2763) * Updated comment for GA4 gtag config * Fjernet UA script * Added description and title after code review * Keywords should be an array, I think. * Remove title, it looks wrong sometimes and shouldnt be fetched like this. * [MIM-1887] UA script for TEST (#2772) UA script for TEST * MIM-1887 gtag and GA_TRACKING_ID removal (#2769) * highchart.es6 gtag removal * AttachmentTablesFigures gtag removal * Highchart.jsx gtag removal * links.tsx gtag removal * Table.tsx gtag removal * nameSearch.jsx gtag removal * searchResultView.tsx gtag removal * error.html gtag removal * ReactGA.tsx removal of file * react-ga dependency removal * GA_TRACKING_ID removal from all files * Bump google-github-actions/auth from 2.1.2 to 2.1.3 (#2757) Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 2.1.2 to 2.1.3. - [Release notes](https://github.com/google-github-actions/auth/releases) - [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md) - [Commits](google-github-actions/auth@v2.1.2...v2.1.3) --- updated-dependencies: - dependency-name: google-github-actions/auth dependency-type: direct:production update-type: version-update:semver-patch ... * Update version number to v2.8.2 * [MIM-1950] MIM-1950:Fikset bug med tidssone for kommende publiseringer (#2756) MIM-1950:Fikset bug med tidssone for kommende publiseringer * Change env name in github action to make jira integration work properly (#2764) * [MIM-1915] Added macro config for keyFigure (#2759) * added macro config for keyFigure * added styling to fix gap to text * fixed formatting * [MIM-1887] Mim 1887 removal of universal analytics (#2763) * Updated comment for GA4 gtag config * Fjernet UA script * Changes to Commits * Added type for renderShowButton onKeyDown event * default.html - UA SCRIPT final removal --------- Co-authored-by: GitHub Actions Bot <> * [MIM-1915] Add divider to key figure macro (#2775) * added divider in keyFigure macro * moved divider logic to keyFigure part --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Carl-OW <142233642+Carl-OW@users.noreply.github.com> Co-authored-by: Carina <47381367+ssb-cgn@users.noreply.github.com> Co-authored-by: Anne-Siri <142512638+annesiri@users.noreply.github.com> Co-authored-by: Glenruben <gle@ssb.no> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Carl-OW
added a commit
that referenced
this pull request
Jul 9, 2024
* highchart.es6 gtag removal * AttachmentTablesFigures gtag removal * Highchart.jsx gtag removal * links.tsx gtag removal * Table.tsx gtag removal * nameSearch.jsx gtag removal * searchResultView.tsx gtag removal * error.html gtag removal * ReactGA.tsx removal of file * react-ga dependency removal * GA_TRACKING_ID removal from all files * Bump google-github-actions/auth from 2.1.2 to 2.1.3 (#2757) Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 2.1.2 to 2.1.3. - [Release notes](https://github.com/google-github-actions/auth/releases) - [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md) - [Commits](google-github-actions/auth@v2.1.2...v2.1.3) --- updated-dependencies: - dependency-name: google-github-actions/auth dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update version number to v2.8.2 * [MIM-1950] MIM-1950:Fikset bug med tidssone for kommende publiseringer (#2756) MIM-1950:Fikset bug med tidssone for kommende publiseringer * Change env name in github action to make jira integration work properly (#2764) * [MIM-1915] Added macro config for keyFigure (#2759) * added macro config for keyFigure * added styling to fix gap to text * fixed formatting * [MIM-1887] Mim 1887 removal of universal analytics (#2763) * Updated comment for GA4 gtag config * Fjernet UA script * Changes to Commits * Added type for renderShowButton onKeyDown event * default.html - UA SCRIPT final removal --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions Bot <> Co-authored-by: Carina <47381367+ssb-cgn@users.noreply.github.com> Co-authored-by: Anne-Siri <142512638+annesiri@users.noreply.github.com>
Carl-OW
added a commit
that referenced
this pull request
Jul 9, 2024
PROD Løft (#2776) * Add PageMap attributes, feature toggle * [MIM-1950] MIM-1950:Fikset bug med tidssone for kommende publiseringer (#2756) MIM-1950:Fikset bug med tidssone for kommende publiseringer * Change env name in github action to make jira integration work properly (#2764) * [MIM-1915] Added macro config for keyFigure (#2759) * added macro config for keyFigure * added styling to fix gap to text * fixed formatting * Add conditional fields, if data is present. * [MIM-1887] Mim 1887 removal of universal analytics (#2763) * Updated comment for GA4 gtag config * Fjernet UA script * Added description and title after code review * Keywords should be an array, I think. * Remove title, it looks wrong sometimes and shouldnt be fetched like this. * [MIM-1887] UA script for TEST (#2772) UA script for TEST * MIM-1887 gtag and GA_TRACKING_ID removal (#2769) * highchart.es6 gtag removal * AttachmentTablesFigures gtag removal * Highchart.jsx gtag removal * links.tsx gtag removal * Table.tsx gtag removal * nameSearch.jsx gtag removal * searchResultView.tsx gtag removal * error.html gtag removal * ReactGA.tsx removal of file * react-ga dependency removal * GA_TRACKING_ID removal from all files * Bump google-github-actions/auth from 2.1.2 to 2.1.3 (#2757) Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 2.1.2 to 2.1.3. - [Release notes](https://github.com/google-github-actions/auth/releases) - [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md) - [Commits](google-github-actions/auth@v2.1.2...v2.1.3) --- updated-dependencies: - dependency-name: google-github-actions/auth dependency-type: direct:production update-type: version-update:semver-patch ... * Update version number to v2.8.2 * [MIM-1950] MIM-1950:Fikset bug med tidssone for kommende publiseringer (#2756) MIM-1950:Fikset bug med tidssone for kommende publiseringer * Change env name in github action to make jira integration work properly (#2764) * [MIM-1915] Added macro config for keyFigure (#2759) * added macro config for keyFigure * added styling to fix gap to text * fixed formatting * [MIM-1887] Mim 1887 removal of universal analytics (#2763) * Updated comment for GA4 gtag config * Fjernet UA script * Changes to Commits * Added type for renderShowButton onKeyDown event * default.html - UA SCRIPT final removal --------- Co-authored-by: GitHub Actions Bot <> * [MIM-1915] Add divider to key figure macro (#2775) * added divider in keyFigure macro * moved divider logic to keyFigure part --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Carl-OW <142233642+Carl-OW@users.noreply.github.com> Co-authored-by: Carina <47381367+ssb-cgn@users.noreply.github.com> Co-authored-by: Anne-Siri <142512638+annesiri@users.noreply.github.com> Co-authored-by: Glenruben <gle@ssb.no> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Carl-OW
added a commit
that referenced
this pull request
Jul 16, 2024
PROD Løft (#2776) * Add PageMap attributes, feature toggle * [MIM-1950] MIM-1950:Fikset bug med tidssone for kommende publiseringer (#2756) MIM-1950:Fikset bug med tidssone for kommende publiseringer * Change env name in github action to make jira integration work properly (#2764) * [MIM-1915] Added macro config for keyFigure (#2759) * added macro config for keyFigure * added styling to fix gap to text * fixed formatting * Add conditional fields, if data is present. * [MIM-1887] Mim 1887 removal of universal analytics (#2763) * Updated comment for GA4 gtag config * Fjernet UA script * Added description and title after code review * Keywords should be an array, I think. * Remove title, it looks wrong sometimes and shouldnt be fetched like this. * [MIM-1887] UA script for TEST (#2772) UA script for TEST * MIM-1887 gtag and GA_TRACKING_ID removal (#2769) * highchart.es6 gtag removal * AttachmentTablesFigures gtag removal * Highchart.jsx gtag removal * links.tsx gtag removal * Table.tsx gtag removal * nameSearch.jsx gtag removal * searchResultView.tsx gtag removal * error.html gtag removal * ReactGA.tsx removal of file * react-ga dependency removal * GA_TRACKING_ID removal from all files * Bump google-github-actions/auth from 2.1.2 to 2.1.3 (#2757) Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 2.1.2 to 2.1.3. - [Release notes](https://github.com/google-github-actions/auth/releases) - [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md) - [Commits](google-github-actions/auth@v2.1.2...v2.1.3) --- updated-dependencies: - dependency-name: google-github-actions/auth dependency-type: direct:production update-type: version-update:semver-patch ... * Update version number to v2.8.2 * [MIM-1950] MIM-1950:Fikset bug med tidssone for kommende publiseringer (#2756) MIM-1950:Fikset bug med tidssone for kommende publiseringer * Change env name in github action to make jira integration work properly (#2764) * [MIM-1915] Added macro config for keyFigure (#2759) * added macro config for keyFigure * added styling to fix gap to text * fixed formatting * [MIM-1887] Mim 1887 removal of universal analytics (#2763) * Updated comment for GA4 gtag config * Fjernet UA script * Changes to Commits * Added type for renderShowButton onKeyDown event * default.html - UA SCRIPT final removal --------- Co-authored-by: GitHub Actions Bot <> * [MIM-1915] Add divider to key figure macro (#2775) * added divider in keyFigure macro * moved divider logic to keyFigure part --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Carl-OW <142233642+Carl-OW@users.noreply.github.com> Co-authored-by: Carina <47381367+ssb-cgn@users.noreply.github.com> Co-authored-by: Anne-Siri <142512638+annesiri@users.noreply.github.com> Co-authored-by: Glenruben <gle@ssb.no> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Carl-OW
added a commit
that referenced
this pull request
Jul 16, 2024
PROD Løft (#2776) * Add PageMap attributes, feature toggle * [MIM-1950] MIM-1950:Fikset bug med tidssone for kommende publiseringer (#2756) MIM-1950:Fikset bug med tidssone for kommende publiseringer * Change env name in github action to make jira integration work properly (#2764) * [MIM-1915] Added macro config for keyFigure (#2759) * added macro config for keyFigure * added styling to fix gap to text * fixed formatting * Add conditional fields, if data is present. * [MIM-1887] Mim 1887 removal of universal analytics (#2763) * Updated comment for GA4 gtag config * Fjernet UA script * Added description and title after code review * Keywords should be an array, I think. * Remove title, it looks wrong sometimes and shouldnt be fetched like this. * [MIM-1887] UA script for TEST (#2772) UA script for TEST * MIM-1887 gtag and GA_TRACKING_ID removal (#2769) * highchart.es6 gtag removal * AttachmentTablesFigures gtag removal * Highchart.jsx gtag removal * links.tsx gtag removal * Table.tsx gtag removal * nameSearch.jsx gtag removal * searchResultView.tsx gtag removal * error.html gtag removal * ReactGA.tsx removal of file * react-ga dependency removal * GA_TRACKING_ID removal from all files * Bump google-github-actions/auth from 2.1.2 to 2.1.3 (#2757) Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 2.1.2 to 2.1.3. - [Release notes](https://github.com/google-github-actions/auth/releases) - [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md) - [Commits](google-github-actions/auth@v2.1.2...v2.1.3) --- updated-dependencies: - dependency-name: google-github-actions/auth dependency-type: direct:production update-type: version-update:semver-patch ... * Update version number to v2.8.2 * [MIM-1950] MIM-1950:Fikset bug med tidssone for kommende publiseringer (#2756) MIM-1950:Fikset bug med tidssone for kommende publiseringer * Change env name in github action to make jira integration work properly (#2764) * [MIM-1915] Added macro config for keyFigure (#2759) * added macro config for keyFigure * added styling to fix gap to text * fixed formatting * [MIM-1887] Mim 1887 removal of universal analytics (#2763) * Updated comment for GA4 gtag config * Fjernet UA script * Changes to Commits * Added type for renderShowButton onKeyDown event * default.html - UA SCRIPT final removal --------- Co-authored-by: GitHub Actions Bot <> * [MIM-1915] Add divider to key figure macro (#2775) * added divider in keyFigure macro * moved divider logic to keyFigure part --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Carl-OW <142233642+Carl-OW@users.noreply.github.com> Co-authored-by: Carina <47381367+ssb-cgn@users.noreply.github.com> Co-authored-by: Anne-Siri <142512638+annesiri@users.noreply.github.com> Co-authored-by: Glenruben <gle@ssb.no> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: MIM-1887