Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIM-1986] Mim 1986 prepend environments in title #2827

Merged
merged 12 commits into from
Jul 18, 2024

Conversation

johnnadeluy
Copy link
Contributor

@johnnadeluy johnnadeluy commented Jul 16, 2024

@github-actions github-actions bot changed the title Mim 1986 prepend environments in title [MIM-1986] Mim 1986 prepend environments in title Jul 16, 2024
@johnnadeluy johnnadeluy marked this pull request as ready for review July 16, 2024 09:56
Copy link

Copy link
Contributor

@ssb-cgn ssb-cgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@johnnadeluy johnnadeluy merged commit 419fbb4 into develop Jul 18, 2024
7 checks passed
Carl-OW pushed a commit that referenced this pull request Jul 24, 2024
* Add a processor for environment prepending in title
MIM-1986

* Add functionality to prepend environment into title tag in head (wip)

* Minor adjustments to header and title regex

* Add logging for testing (in test)

* Fetch environment from baseUrl in app config

* Fix environment string on baseUrl match

* Fetch environment string from app config instead

* Minor code refactoring

* Use optional chain for app config

* Move getting environment string functionality to utils

* Add environment string to admin tool applications dashboard and bestbet too
@johnnadeluy johnnadeluy deleted the MIM-1986_prepend_environments_in_title branch July 29, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants