Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIM-2005] delete_nais.yaml updates #2937

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

Carl-OW
Copy link
Contributor

@Carl-OW Carl-OW commented Oct 9, 2024

@github-actions github-actions bot changed the title gh-ssb to gh-ssbno in delete_nais.yaml [MIM-2005] gh-ssb to gh-ssbno in delete_nais.yaml Oct 9, 2024
@Carl-OW Carl-OW changed the title [MIM-2005] gh-ssb to gh-ssbno in delete_nais.yaml [MIM-2005] delete_nais.yaml updates Oct 9, 2024
Copy link

sonarqubecloud bot commented Oct 9, 2024

service_account: "gh-ssb@nais-management-b3a7.iam.gserviceaccount.com"
token_format: "access_token"
- id: "get-credentials"
workload_identity_provider: 'projects/906675412832/locations/global/workloadIdentityPools/ssb-identity-pool/providers/github-oidc-provider'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to look into whether workload_indentity_provider and service_account should be secured as variables since they can contain sensitive information

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a task in the Backlog that adresses the issue

Copy link
Contributor

@johnnadeluy johnnadeluy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Carl-OW Carl-OW merged commit 3c835c9 into develop Oct 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants