-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixedas(present, absent) constraint does not actually ensure edges are present or absent. #572
Comments
One option would be to add another argument in front, e.g., |
… fixes the dyads. Both fixedas() and fixallbut() constraints now warn when given a network whose size does not match the LHS network's. references #572
I guess I'm not sure what the use case is here. Was the goal to constrain some dyads to their initial values, and allow others to be toggled? Or was it supposed to fix some dyads' statuses to present/absent and allow others to be toggled. |
The main use case is to fix (i.e., condition on) a specific set of dyads at their initial values. I don't know if anyone has relied on the |
@CarterButts , @martinamorris , @drh20drh20 , @kecoli thoughts? |
I don't have strong feelings about this -- but unless there's a strong use case made for the present/absent arguments, it seems easiest to deprecate them and just use this constraint for setting a passed edgelist to the observed values. |
Since there isn't currently an API for a constraint to modify the network, the most it can do anyway is to raise an error. So, I guess the best I can do is
|
The constraint simply takes the provided edgelist and fixes the corresponding dyads. It doesn't check if the edges in
present
are present, inabsent
are absent, and it doesn't modify the network such that they are. Passing an argument aspresent
has the exact same effect as passing it asabsent
.It was originally implemented by Kirk Li in response to a ticket by @CarterButts (https://github.com/statnet/ergm-private/issues/49), so the question is, what do we do with it?
The text was updated successfully, but these errors were encountered: