Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.11.4 release candiate to correct Doc fixes and C warnings flagged by CRAN in #21 #23

Merged
merged 9 commits into from
Dec 10, 2023

Conversation

skyebend
Copy link
Contributor

@skyebend skyebend commented Dec 9, 2023

#21

Todo (skye):

  • rsiena function warnings from windevel
  • update changelog
  • run full package check
  • release to CRAN

@skyebend skyebend requested a review from mbojan December 9, 2023 08:27
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7d10a45) 62.59% compared to head (f95c591) 62.59%.

❗ Current head f95c591 differs from pull request most recent head edbcb91. Consider uploading reports for the commit edbcb91 to get more accurate results

Files Patch % Lines
src/wtedgetree.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   62.59%   62.59%           
=======================================
  Files          20       20           
  Lines        4008     4008           
=======================================
  Hits         2509     2509           
  Misses       1499     1499           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mbojan mbojan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems to be OK and my r-devel build and check completed with flying colors.

@skyebend skyebend merged commit 24fd41f into master Dec 10, 2023
12 checks passed
@skyebend skyebend deleted the doc-fix branch December 10, 2023 09:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants