Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): use if condition to check rollout status #24

Merged
merged 3 commits into from
Jan 10, 2023
Merged

fix(ci): use if condition to check rollout status #24

merged 3 commits into from
Jan 10, 2023

Conversation

padlar
Copy link
Contributor

@padlar padlar commented Jan 10, 2023 •
edited
Loading

Print logs and events if rollout status doesn't succeed.

Relates to #21.

fix(ci): use if condition to check rollout status
371e6bb 
Print logs and events if rollout status doesn't succeed.
@padlar padlar requested a review from a team as a code owner January 10, 2023 11:15
erikgb
erikgb reviewed Jan 10, 2023
View reviewed changes
Copy link
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, but added one comment/question.

Makefile Show resolved Hide resolved
@erikgb
Copy link
Member

erikgb commented Jan 10, 2023

Maybe also link this PR to #21. It does not fix it, but related.

change the order of cmds, events first followed by log
b9fa95e 
Signed-off-by: Sunil Shivanand <sunil.shivanand@statnett.no>
erikgb
erikgb approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padlar padlar merged commit 8f8f173 into statnett:main Jan 10, 2023
@padlar padlar deleted the run-failed-conditional-commands branch January 10, 2023 15:00
This was referenced Jan 10, 2023
Closed
Closed
@mikaelol mikaelol mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendikp bendikp bendikp left review comments

@erikgb erikgb erikgb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@padlar @erikgb @bendikp