chore: bump K8s dependencies to 1.27.x #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
changed the title
erikgb
force-pushed
the
bump-dependencies
branch
2 times, most recently
from
ca63f55
to
55be6a3
Compare
erikgb
changed the title
tenstad
reviewed
May 30, 2023
tenstad
approved these changes
May 30, 2023
bendikp
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades all K8s dependencies to the latest releases (based on K8s 1.27). There are quite a few breaking changes in the latest controller-runtime release that needs to be addressed. And also some new deprecations, that are also fixed in this PR.
We override the new default
RestMapperin controller-runtime because we don't need the dynamic nature that the new default mapper has. We only do discovery on startup, and the dynamic mapper in controller-runtime seems to be full of bugs at present and IMO not production-ready, ref. kubernetes-sigs/controller-runtime#2345, kubernetes-sigs/controller-runtime#2349, kubernetes-sigs/controller-runtime#2354 (and probably more to come).