Ensure Uniform constructed on bounded interval #218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In looking at lints (#216, has some of the discussion there) adjacently found that Uniform would allow infinite support. I don't know enough to say if this is well defined mathematically, but a few implications I thought of:
sample
will fail while usingrand
's UniformSamplercdf
andsf
have odd end behaviors for the unbounded end, is F(x = INF) = 1 if X ~ Uni(a, INF)? Equals INF isn't good math, but is valid value for floatsThere may be others, but this PR would disallow construction of such a distribution,
sf
was implemented to have behavior for infinite support, butcdf
was not. If someone can declare how it should work, then we can reallow it and implement all the behavior for it.