Remove StatsError
type & replace Result<T, StatsError>
with Option<T>
#258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly looking to move the error discussion forward by seeing how this would look like.
This is a possible solution to #221, and effectively the extreme opposite of #247.
Why do this? Well, a lot of functions look something like this:
Even if they have more lines, functions often only return one specific error variant, which can be replaced by
Option::None
. A user can then check the documentation to quickly figure out why it's returningOption::None
in most cases (invalid params of some sort).I opened this as a draft because there are some functions that should probably have a concrete error type, either for future-proofing or because they already return multiple error variants.