-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all instances of StatsError
with custom error types or Option<T>
#284
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 93.75% 93.94% +0.19%
==========================================
Files 53 52 -1
Lines 11800 11783 -17
==========================================
+ Hits 11063 11070 +7
+ Misses 737 713 -24 ☔ View full report in Codecov by Sentry. |
Wondering if it's valuable to emit a |
I'll leave this PR as-is for now and update it then.. If i revert any of the changes here then I also have to revert the removal of
Maybe. I'd say it's a bit out of scope for this PR though, might make sense to open an issue for it |
This is not a breaking change because these functions are not part of the public API.
93a3ca6
to
e87cde0
Compare
that makes sense, odd that deleting |
@YeungOnion Not sure what happened, but |
Presumably, the commit I force pushed added it back into the tree 🙃 |
Closes #221, I think.
Added some new error types similar to the ones introduced in #265.
Some functions only got the simpler
Option<T>
return type if they only have one error condition. The functions in MultivariateNormal also have a simple Option return type because they're non-public, and it's expected that the preconditions are fulfilled on every call anyways. No need for fancy error messages (and can be easily changed if need be)