Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow ci to continue on error for newest nightly #291

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

YeungOnion
Copy link
Contributor

@YeungOnion YeungOnion commented Sep 13, 2024

  • ci: continue past errors of true nightly for coverage

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.94%. Comparing base (a40ba07) to head (8c75906).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files          52       52           
  Lines       11783    11783           
=======================================
  Hits        11070    11070           
  Misses        713      713           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YeungOnion
Copy link
Contributor Author

this should be completely resilient against future issues with nightly and we can pin different nightlies that work for us.

I'd like the red x at the PR level to go away, but perhaps this will change sometime (see actions/runner#2347)

@YeungOnion YeungOnion merged commit 0c29b44 into statrs-dev:master Sep 13, 2024
10 of 11 checks passed
@FreezyLemon
Copy link
Contributor

This is probably the best solution 👍 Feels bad to have CI fail just because of a broken nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants