Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: drop RPC flag and add REST API flags #25

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented Feb 13, 2024

Related to removal of RPC API support in:

@alrevuelta

@jakubgs jakubgs requested review from yakimant and apentori February 13, 2024 21:12
@jakubgs jakubgs self-assigned this Feb 13, 2024
@jakubgs jakubgs force-pushed the drop-rpc-api branch 5 times, most recently from 61f80a2 to e470579 Compare February 13, 2024 21:50
Copy link
Contributor

@apentori apentori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Member

@yakimant yakimant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks for api.sh!

@alrevuelta
Copy link

Anything left here? We plan to merge waku-org/nwaku#2416 soon. Unsure if you use releases or latest commits. But for sure that PR will be shipped with nwaku release v0.26.0.

Can we merge?

Related to removal of RPC API support in:
https://github.com/waku-org/ nwaku/pull/2416

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs merged commit 2aed29d into master Feb 29, 2024
@jakubgs jakubgs deleted the drop-rpc-api branch February 29, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants