Use tree height instead of chunk limit for merkleizer #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More closely matches implementation and avoids generic bloat. Renamed to avoid accidental limit-vs-height confusion.
zah
reviewed
Jan 8, 2024
|
|
||
| template getChunkCount*(m: SszMerkleizer): uint64 = | ||
| template limit*(T: type SszMerkleizer2): Limit = | ||
| if T.height == 0: 0'i64 else: 1'i64 shl (T.height - 1) |
There was a problem hiding this comment.
Hrm, what about the cases where the limit is not a power of 2? We have to review more carefully how this code is being used.
There was a problem hiding this comment.
no critical usages, ie it doesn't materially matter since all trees are extended to power-of-2 anyway
|
nim-lang/Nim#23188 should fix the CI issue in |
|
@tersec indeed it did: https://github.com/status-im/nim-ssz-serialization/actions/runs/7490848447 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More closely matches implementation and avoids generic bloat.
Renamed to avoid accidental limit-vs-height confusion.