Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible memory issue when sharing data between threads. #48

Open
vanyle opened this issue Apr 10, 2024 · 0 comments
Open

Possible memory issue when sharing data between threads. #48

vanyle opened this issue Apr 10, 2024 · 0 comments

Comments

@vanyle
Copy link

vanyle commented Apr 10, 2024

See nim-lang/Nim#23485

Inside ntu.nim:

When spawing new threads, a ThreadPayload is given. This ThreadPayload contains a ref type, TestSpec.
This is not allowed.

The test: TestSpec variable is shared between the 2 threads and could lead to crashes as ref do not use atomic reference counting.

This can lead to flaky tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vanyle