Check that ref
types are not passed to threads
#23485
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For memory reasons, types containing
ref
s should not be passed to the argument of a thread.This PR enforces this.
Because the macro system is not available from thread as thread is imported by the system module, we use typedesc (an implementation suggested by beef331 here).
The code recursively checks that the object passed does not contains
ref
inside nested fields.A test is added to make sure this actually works.