Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ssz stint support #1046

Merged
merged 1 commit into from
May 20, 2020
Merged

remove ssz stint support #1046

merged 1 commit into from
May 20, 2020

Conversation

arnetheduck
Copy link
Member

No description provided.

tersec
tersec reviewed May 20, 2020
View reviewed changes
tests/helpers/debug_ssz.nim
@@ -1,82 +0,0 @@
# beacon_chain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole file is just dead code removal and not per se related to the stint removal, correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, there's an ncli that does the same

@tersec
Copy link
Contributor

tersec commented May 20, 2020

Jenkins CI error is strange:

Building: install/usr/lib/libbacktrace.a
Building: Nim compiler
Building: install/usr/lib/libbacktracenim.a
vendor/nimbus-build-system/makefiles/targets.mk:40: recipe for target 'build-nim' failed
make[2]: *** [build-nim] Error 1
vendor/nimbus-build-system/makefiles/targets.mk:66: recipe for target 'vendor/nimbus-build-system/vendor/Nim/bin/nim' failed
make[1]: *** [vendor/nimbus-build-system/vendor/Nim/bin/nim] Error 2
vendor/nimbus-build-system/makefiles/targets.mk:54: recipe for target 'update-common' failed
make: *** [update-common] Error 2
script returned exit code 2

@arnetheduck arnetheduck merged commit a38eddc into devel May 20, 2020
@arnetheduck arnetheduck deleted the ssz-no-stint branch May 28, 2020 05:05
@tersec tersec mentioned this pull request Jun 18, 2020
Closed
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tersec tersec tersec approved these changes

@zah zah zah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnetheduck @tersec @zah