avoid unnecessary recompression in block protocol #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etan-status
approved these changes
Apr 16, 2022
| peer.updateRequestQuota(blockResponseCost) | ||
| peer.awaitNonNegativeRequestQuota() | ||
|
|
||
| await response.writeRawBytes(bytes, []) # phase0 bytes | ||
| await response.writeBytesSZ(uncompressedLen, bytes, []) # phase0 |
There was a problem hiding this comment.
Suggested change
| await response.writeBytesSZ(uncompressedLen, bytes, []) # phase0 | |
| await response.writeBytesSZ(uncompressedLen, bytes, []) # phase0 bytes |
(above at line 284, the comment was not deleted. I guess it got removed here unintentionally)
Blocks can be sent straight from compressed data sources
arnetheduck
force-pushed
the
no-recompress
branch
from
29c05a1
to
ca04b9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocks can be sent straight from compressed data sources