Fix #3760. #3768
Merged
Fix #3760. #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cheatfate
commented
Jun 16, 2022
•
cheatfate
commented
- Fix KeyManager API do not follows specification when importing keys. #3760
- Add test vectors for Keystore Management API keystore deserialization.
|
GJ. What a crazy serialization format, packing JSON into string into JSON 😅 |
etan-status
approved these changes
Jun 16, 2022
arnetheduck
reviewed
Jun 17, 2022
| @@ -336,6 +336,206 @@ proc runTests {.async.} = | |||
| ] | |||
| ) | |||
|
|
|||
| suite "Serialization/deserialization " & preset(): | |||
There was a problem hiding this comment.
nice tests! These kinds of tests would be useful for all the rest-json serialized types
zah
reviewed
Jun 17, 2022
| @@ -1908,44 +1909,82 @@ proc writeValue*(writer: var JsonWriter[RestJson], | |||
| value: KeystoresAndSlashingProtection) {. | |||
| raises: [IOError, Defect].} = | |||
| writer.beginRecord() | |||
| writer.writeField("keystores", value.keystores) | |||
| let keystores = | |||
| block: | |||
There was a problem hiding this comment.
You can simplify this with mapIt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.