avoid quadratic attestation queue iteration #5288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
every attestation is processed with a new wall time so we end up iterating over all attestations for every attestation we queue - this is 4% of cpu time on a subscribe-all-subnets node * remove redundant zero checks - block root must be an existing block and therefore cannot be zero * simplify "hasn't-voted" check to root only (isZeroMemory is dubiously implemented for objects)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
every attestation is processed with a new wall time so we end up iterating over all attestations for every attestation we queue - this is 4% of cpu time on a subscribe-all-subnets node