-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared validator pubkey #5883
Merged
Merged
Shared validator pubkey #5883
Commits on Feb 12, 2024
-
This PR allows sharing the pubkey data between validators by using a thread-local cache for pubkey data, netting about a 400mb mem usage reduction on holesky due to us keeping 3 permanent + several ephemeral state copies in memory at all times and each state copy holding a full validator. The PR also introduces a hash cache for the key which gives ~14% speedup for a full state `hash_tree_root` - the key makes up for a large part of the `Validator` htr time. Finally, the time it takes to copy a state goes down as well from ~80m ms to ~60, for reasons similar to htr. We use a `ptr` even if a `ref` could in theory have been used - there is not much practical benefit to a `ref` (given it's mutable) while a `ptr` is cheaper and easier to copy (when copying temporary states). We could go further and cache a cooked pubkey but it turns out this is quite intrusive - in all the relevant places, we're already using a cooked key from the immutable validator data so there are no immediate performance gains of doing so while managing the compressed -> cooked key mapping would become more difficult - something for a future PR perhaps.
Configuration menu - View commit details
-
Copy full SHA for 71001d7 - Browse repository at this point
Copy the full SHA 71001d7View commit details
Commits on Feb 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7b37fd2 - Browse repository at this point
Copy the full SHA 7b37fd2View commit details
Commits on Feb 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 641dede - Browse repository at this point
Copy the full SHA 641dedeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c964803 - Browse repository at this point
Copy the full SHA c964803View commit details -
Configuration menu - View commit details
-
Copy full SHA for d92f872 - Browse repository at this point
Copy the full SHA d92f872View commit details
Commits on Feb 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 504a0ec - Browse repository at this point
Copy the full SHA 504a0ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for e577428 - Browse repository at this point
Copy the full SHA e577428View commit details -
Configuration menu - View commit details
-
Copy full SHA for be3ff0d - Browse repository at this point
Copy the full SHA be3ff0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f66c288 - Browse repository at this point
Copy the full SHA f66c288View commit details -
Update beacon_chain/spec/eth2_merkleization.nim
Co-authored-by: Etan Kissling <etan@status.im>
Configuration menu - View commit details
-
Copy full SHA for f448766 - Browse repository at this point
Copy the full SHA f448766View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a980a2 - Browse repository at this point
Copy the full SHA 1a980a2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.