Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid --gc:arc issue in validator key caching #6203

Merged
merged 2 commits into from
Apr 16, 2024
Merged

avoid --gc:arc issue in validator key caching #6203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2af07b5
avoid `--gc:arc` issue in validator key caching
etan-status Apr 15, 2024
fd92101
Update beacon_chain/spec/eth2_merkleization.nim
etan-status Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions beacon_chain/spec/eth2_merkleization.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,10 @@ func init*(T: type HashedValidatorPubKey, key: ValidatorPubKey): HashedValidator
# The interface of HashSet is such that we must construct a full
# instance to check if it's in the set - then we can return that
# instace and discard the one we just created temporarily
keys[tmp]
addr keys[tmp][]
except KeyError:
raiseAssert "just checked"
else:
tmp
addr tmp[]

HashedValidatorPubKey(value: addr cached[])
HashedValidatorPubKey(value: cached) # https://github.com/nim-lang/Nim/issues/23505
Loading