add: column support to ENR, Metadata and Request Manager #6741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnxsh
changed the title
custody subnet count support to ENR and Metadata
tersec
reviewed
Dec 5, 2024
tersec
reviewed
Dec 5, 2024
tersec
reviewed
Dec 5, 2024
tersec
reviewed
Dec 5, 2024
tersec
reviewed
Dec 5, 2024
tersec
reviewed
Dec 8, 2024
tersec
reviewed
Dec 8, 2024
tersec
reviewed
Dec 8, 2024
tersec
reviewed
Dec 8, 2024
tersec
reviewed
Dec 8, 2024
| {.async: (raises: [CancelledError]).} = | ||
| var peer: Peer | ||
| try: | ||
| peer = await rman.network.peerPool.acquire() |
There was a problem hiding this comment.
It seems like peer is never re-assigned, and right now, it's notionally briefly declared but default-initialized to some meaningless zero-value. It seems like one could do something like var peer = await rman ... outside the try, equivalently but avoiding this?
tersec
reviewed
Dec 8, 2024
tersec
reviewed
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
custody_subent_countto both ENR and Metadata as corresponding field, in peerDAS, it helps peers to filer other peers from the peer pool asfull nodesandsupernodes.