adds peerdas-supernode flag #6764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in subscribeAllSubnets
tersec
reviewed
Dec 16, 2024
beacon_chain/conf.nim
Outdated
| peerdasSupernode* {. | ||
| defaultValue: false, | ||
| desc: "Subscribe to all column subnets, thereby becoming a peerdas supernode" | ||
| name: "peerdas-supernode" .}: bool |
There was a problem hiding this comment.
debug-peerdas-supernode would be nicer.
https://nimbus.guide/options.html
Any
debug-prefixed flags are considered ephemeral and subject to removal without notice.
Until Fulu becomes production, this is a debugging flag for devnet/testnet/Kurtosis purposes, so shouldn't be documented or supported-per-se.
Also, probably, hidden, because again, it's not really part of the supported UI/UX yet, certainly before Fulu is in public testnets (months from now).
It does seem possible it will at some point, but no need to do that prematurely.
tersec
reviewed
Dec 16, 2024
tersec
reviewed
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to measure resources efficiently it's beneficial to have a separate peerdas supernode flag, this is because if we launch a peerdas supernode on
subscribe-all-subnets, then we also end up subscribing to all attnets and syncnets, which would thereby use of more resources to run the peerdas supernode.