extended validation #812
Merged
extended validation #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
force-pushed
the
ada
branch
4 times, most recently
from
a49dea6 to
c218c2f
Compare
tersec
changed the title
arnetheduck
reviewed
Mar 31, 2020
…and document this constraint
…blocks across multiple forks
|
I'll address remaining issues in a further PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure that one can't (easily) subscribe to a topic without providing a validator, to make the default action more correct,
separate the action/validating because
nim-beacon-chainwill adopt/support more split roles in future, andensure that validation happens from time 0 for subscribing to a topic.
Implements #122 (comment)
Finalizes under
make eth2_network_simulationand local testnet locally.This doesn't contain the necessary tests, but it would be useful to enable completing #769 regardless. Also, e.g.,
make eth2_network_simulationsomewhat integration-tests this already, just doesn't have unit tests.