Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Community permissions] Implement backend to change which addresses are shared with the Owner #11153

Closed
jrainville opened this issue Jun 19, 2023 · 1 comment · Fixed by #11557
Assignees
Labels
E:Desktop Community Shared Addresses Selection Implementation of the Shared Addresses feature for joining communities and also for edits feature
Milestone

Comments

@jrainville
Copy link
Member

Description

As part of "Changing shared address settings from within Community" (WIP design: https://www.figma.com/file/uHwhhUsne96HBhkunsD7Po/WIP-flows?type=design&node-id=8-34093&t=kwGGwrG4wikQ1eK5-0)
we need to implement an API that users can use to change which address they share with the owner.

The API will accept a community ID and a list of addresses.

Those addresses will then be sent to the control node, which will save them instead of the old ones (old ones are deleted/replaced).

Both the control and the user node will need to do a verification on the new addresses to make sure that the user still fulfills the requirements. If they do not, they lose the privilege they had.

No need to implement any UI for this. This is backend only, so mostly status-go, but if possible, do the service, controller, module and view code too (should be just a chain of calls up to status-go). You can just use a random placeholder UI element if you need to test it, but status-go tests can do the trick.

Acceptance Criteria

  • There is a new status-go API that members of a community can call to change their shared addresses
  • Once it is called, the control node updates the addresses in their DB and uses the new ones instead
  • If the new addresses do not fulfill all the permissions, the user loses privilege
    • If they were admin and no longer fulfill the admin permission, they become member (if they fulfill the member permission if it exists)
    • If they were member and no longer fulfill the member permission, they are kicked
    • If there were channel permissions and they no longer fulfill them, they lose read or write access depending on the type.
@jrainville
Copy link
Member Author

status-go PR: status-im/status-go#3723

@jrainville jrainville added E:Desktop Community Shared Addresses Selection Implementation of the Shared Addresses feature for joining communities and also for edits and removed E:Communities labels Jul 13, 2023
jrainville added a commit that referenced this issue Jul 17, 2023
Fixes #11153

Adds `editSharedAddressesWithAuthentication` in the chat_section view to be called from QML.

Also adds the `communityEditSharedAddressesSucceeded` and `communityEditSharedAddressesFailed` signals in the communities module to be used by QML to know if it worked.
@jrainville jrainville moved this from In Progress to Code review in Status Desktop/Mobile Board Jul 17, 2023
jrainville added a commit that referenced this issue Jul 18, 2023
Fixes #11153

Adds `editSharedAddressesWithAuthentication` in the chat_section view to be called from QML.

Also adds the `communityEditSharedAddressesSucceeded` and `communityEditSharedAddressesFailed` signals in the communities module to be used by QML to know if it worked.
jrainville added a commit that referenced this issue Jul 19, 2023
Fixes #11153

Adds `editSharedAddressesWithAuthentication` in the chat_section view to be called from QML.

Also adds the `communityEditSharedAddressesSucceeded` and `communityEditSharedAddressesFailed` signals in the communities module to be used by QML to know if it worked.
@github-project-automation github-project-automation bot moved this from Code review to Done in Status Desktop/Mobile Board Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Desktop Community Shared Addresses Selection Implementation of the Shared Addresses feature for joining communities and also for edits feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant