Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC][UI - Wallet Stability] Wallet root store and shared store improvements #14712

Open
3 of 5 tasks
noeliaSD opened this issue May 10, 2024 · 1 comment
Open
3 of 5 tasks

Comments

@noeliaSD
Copy link
Contributor

noeliaSD commented May 10, 2024

Description

There are some stores that are declared as Singletons. This fact introduce the following issues, among others:

  • It creates a dependency on context properties.
  • It breaks unit tests / storybook pages.
  • It makes the code more complex and has dificult maintenance.
  • Some components become copled and not isolated.

By following the approach agreed in here, work on updating these stores:

  1. status-desktop/ui/app/AppLayouts/Wallet/stores/RootStore.qml
  2. status-desktop/ui/imports/shared/stores/RootStore.qml

Tasks:

@noeliaSD
Copy link
Contributor Author

noeliaSD commented May 14, 2024

@micieslak please take a look at it and break it down if necessary!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants