-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make stores typed and disambiguated by prefixes if needed #14801
Comments
5 tasks
Seitseman
added a commit
that referenced
this issue
May 31, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 3, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 3, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 5, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 5, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 5, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 7, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 7, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 10, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 10, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 12, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 17, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 20, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 21, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 21, 2024
adding types instead of var for stores used in qml components fixes: #14801
Seitseman
added a commit
that referenced
this issue
Jun 24, 2024
adding types instead of var for stores used in qml components fixes: #14801
micieslak
pushed a commit
that referenced
this issue
Aug 22, 2024
Adding types instead of var for stores used in qml components Closes: #14801
micieslak
pushed a commit
that referenced
this issue
Aug 22, 2024
Adding types instead of var for stores used in qml components Closes: #14801
micieslak
pushed a commit
that referenced
this issue
Aug 22, 2024
Adding types instead of var for stores used in qml components Closes: #14801
micieslak
pushed a commit
that referenced
this issue
Aug 22, 2024
Adding types instead of var for stores used in qml components Closes: #14801
micieslak
pushed a commit
that referenced
this issue
Aug 27, 2024
Adding types instead of var for stores used in qml components Closes: #14801
micieslak
pushed a commit
that referenced
this issue
Aug 27, 2024
Adding types instead of var for stores used in qml components Closes: #14801
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Search for
property var .*Store
gives long list of occurrences where stores are not typed. It makes the code more difficult to read and navigate.E.g.:
Fixing that would make a situation more clear and it would be good starting point for further refactor of stores.
Moreover in some places it may be beneficial to introduce aliases, e.g.:
to disambiguate
RootStore
- this name is repeated in many directories and usually it's not clear at first glance which one is used in given place. Prefixes may help a bit with that.The text was updated successfully, but these errors were encountered: