Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stores typed and disambiguated by prefixes if needed #14801

Closed
Tracked by #14712
micieslak opened this issue May 15, 2024 · 0 comments · Fixed by #15011
Closed
Tracked by #14712

Make stores typed and disambiguated by prefixes if needed #14801

micieslak opened this issue May 15, 2024 · 0 comments · Fixed by #15011

Comments

@micieslak
Copy link
Member

Description

Screenshot from 2024-05-15 23-25-15

Search for property var .*Store gives long list of occurrences where stores are not typed. It makes the code more difficult to read and navigate.

E.g.:

Screenshot from 2024-05-15 23-21-30

Fixing that would make a situation more clear and it would be good starting point for further refactor of stores.

Moreover in some places it may be beneficial to introduce aliases, e.g.:

import AppLayouts.Wallet.stores 1.0 as WalletStores

StackLayout {
    property WalletStores.RootStore rootStore

to disambiguate RootStore- this name is repeated in many directories and usually it's not clear at first glance which one is used in given place. Prefixes may help a bit with that.

@noeliaSD noeliaSD added this to the 2.30.0 Beta milestone May 16, 2024
Seitseman added a commit that referenced this issue May 31, 2024
adding types instead of var for stores used in qml components
fixes: #14801
Seitseman added a commit that referenced this issue Jun 3, 2024
adding types instead of var for stores used in qml components
fixes: #14801
@Seitseman Seitseman linked a pull request Jun 3, 2024 that will close this issue
Seitseman added a commit that referenced this issue Jun 3, 2024
adding types instead of var for stores used in qml components
fixes: #14801
Seitseman added a commit that referenced this issue Jun 5, 2024
adding types instead of var for stores used in qml components
fixes: #14801
Seitseman added a commit that referenced this issue Jun 5, 2024
adding types instead of var for stores used in qml components
fixes: #14801
Seitseman added a commit that referenced this issue Jun 5, 2024
adding types instead of var for stores used in qml components
fixes: #14801
Seitseman added a commit that referenced this issue Jun 7, 2024
adding types instead of var for stores used in qml components
fixes: #14801
Seitseman added a commit that referenced this issue Jun 7, 2024
adding types instead of var for stores used in qml components
fixes: #14801
Seitseman added a commit that referenced this issue Jun 10, 2024
adding types instead of var for stores used in qml components
fixes: #14801
Seitseman added a commit that referenced this issue Jun 10, 2024
adding types instead of var for stores used in qml components
fixes: #14801
Seitseman added a commit that referenced this issue Jun 12, 2024
adding types instead of var for stores used in qml components
fixes: #14801
Seitseman added a commit that referenced this issue Jun 17, 2024
adding types instead of var for stores used in qml components
fixes: #14801
Seitseman added a commit that referenced this issue Jun 20, 2024
adding types instead of var for stores used in qml components
fixes: #14801
Seitseman added a commit that referenced this issue Jun 21, 2024
adding types instead of var for stores used in qml components
fixes: #14801
Seitseman added a commit that referenced this issue Jun 21, 2024
adding types instead of var for stores used in qml components
fixes: #14801
Seitseman added a commit that referenced this issue Jun 24, 2024
adding types instead of var for stores used in qml components
fixes: #14801
@noeliaSD noeliaSD modified the milestones: 2.30.0 Beta, 2.31.0 Beta Jul 15, 2024
@micieslak micieslak self-assigned this Aug 22, 2024
micieslak pushed a commit that referenced this issue Aug 22, 2024
Adding types instead of var for stores used in qml components

Closes: #14801
micieslak pushed a commit that referenced this issue Aug 22, 2024
Adding types instead of var for stores used in qml components

Closes: #14801
micieslak pushed a commit that referenced this issue Aug 22, 2024
Adding types instead of var for stores used in qml components

Closes: #14801
micieslak pushed a commit that referenced this issue Aug 22, 2024
Adding types instead of var for stores used in qml components

Closes: #14801
micieslak pushed a commit that referenced this issue Aug 27, 2024
Adding types instead of var for stores used in qml components

Closes: #14801
micieslak pushed a commit that referenced this issue Aug 27, 2024
Adding types instead of var for stores used in qml components

Closes: #14801
@alaibe alaibe closed this as completed in 2275fe4 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants