Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a group admin, I want to remove a user from a group using the member list #16130

Closed
jrainville opened this issue Aug 15, 2024 · 5 comments · Fixed by #16360
Closed

As a group admin, I want to remove a user from a group using the member list #16130

jrainville opened this issue Aug 15, 2024 · 5 comments · Fixed by #16360

Comments

@jrainville
Copy link
Member

Description

Currently, the only way to remove someone, as an admin, from a group is to click the kebab menu at the top and select the "Add/remove from group" option.

Discord makes it simpler by being able to right click on a user in the member list and remove from there.

I suggest putting the option above "Mark as untrusted". I would call it "Remove from group"
image

It could even be put in a different section (new separator)
cc @benjthayer for your ideas.

Acceptance Criteria

  • As an admin, right-clicking a member of a group chat in the member list shows the option to remove them from the group
  • Clicking that new option removes that user
  • Usual member removal stuff happens:
    • The user can no longer send messages to the chat or see new messages
    • People see updated list of members
@benjthayer
Copy link

Description

Currently, the only way to remove someone, as an admin, from a group is to click the kebab menu at the top and select the "Add/remove from group" option.

Discord makes it simpler by being able to right click on a user in the member list and remove from there.

I suggest putting the option above "Mark as untrusted". I would call it "Remove from group" image

It could even be put in a different section (new separator) cc @benjthayer for your ideas.

Acceptance Criteria

  • As an admin, right-clicking a member of a group chat in the member list shows the option to remove them from the group

  • Clicking that new option removes that user

  • Usual member removal stuff happens:

    • The user can no longer send messages to the chat or see new messages
    • People see updated list of members

Nice idea - do you think we should make these controls dynamic so they change based on where the admin is accessing the profile menu from?

I.e. if they are right-clicking a user in a group chat, we can include Remove from group but if they are right-clicking the user in the context of a community, we can include the options to Kick user and Ban user. I can see that being quite useful for quickfire moderation.

I have a feeling these controls should be in their own section of the menu so they are more clearly delineated from the controls that are omnipresent across all contexts.

@jrainville
Copy link
Member Author

Nice idea - do you think we should make these controls dynamic so they change based on where the admin is accessing the profile menu from?

I.e. if they are right-clicking a user in a group chat, we can include Remove from group but if they are right-clicking the user in the context of a community, we can include the options to Kick user and Ban user. I can see that being quite useful for quickfire moderation.

Good idea! I didn't think of the community context, but it makes a lot of sense!

I have a feeling these controls should be in their own section of the menu so they are more clearly delineated from the controls that are omnipresent across all contexts.

I agree!

@jrainville jrainville modified the milestones: 2.31.0 Beta, 2.32.0 Beta Aug 26, 2024
@iurimatias iurimatias self-assigned this Sep 5, 2024
@benjthayer
Copy link

Hey @jrainville, flows for the community context menus containing Ban and Kick actions are now ready:

https://www.figma.com/design/qHfFm7C9LwtXpfdbxssCK3/Kuba%E2%8E%9CDesktop---Communities?node-id=54395-99078&t=7RwDONOwdy7qOmoZ-4

cc @xAlisher

@jrainville
Copy link
Member Author

@benjthayer looks good. @iurimatias I think you can do those changes in this issue as well, it's all the same component. The backend calls are different though, so if you prefer, you can create a new issue

@iurimatias
Copy link
Member

Confirmed, I will take care of this issue once the ProfileContextMenu refactor is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment